Skip to content

Feat/5.0#802

Closed
QingWei-Li wants to merge 12 commits intomasterfrom
feat/5.0
Closed

Feat/5.0#802
QingWei-Li wants to merge 12 commits intomasterfrom
feat/5.0

Conversation

@QingWei-Li
Copy link
Member

@QingWei-Li QingWei-Li commented Mar 31, 2019 •
edited
Loading

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

The other two features I don't plan to develop. Not much effect.

@docsifyjs/core @jhildenbiddle

First of all, I have to apologize.

I haven't read the issues for a long time and haven't noticed your email. I may have to leave this project.

I have promoted @timaschew to owner and hope that you can continue to maintain docsify.

This is my last contribution to docsify. If you feel that there is no problem, then I will release 5.0. And give the release permission to your.

@QingWei-Li
Copy link
Member Author

QingWei-Li commented Mar 31, 2019

@timaschew
If you need permission to post, please let me know your npm account.

@timaschew
Copy link
Member

timaschew commented Mar 31, 2019 •
edited
Loading

As @jhildenbiddle mentioned here: #657 (comment)
I agree with him to delay this PR (bump to 5.0) until some bugs are fixed which should be released as 4.x
Merging this without bumping the major version seems not an option since this PR contains some breaking changes like the syntax for the helpers.

@timaschew timaschew mentioned this pull request Mar 31, 2019
Closed
@timaschew timaschew mentioned this pull request Apr 16, 2019
Closed
8 tasks
@timaschew timaschew added this to the 5.0 milestone Apr 23, 2019
@anikethsaha anikethsaha mentioned this pull request Nov 21, 2019
Closed
@stale
Copy link

stale bot commented Feb 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 4, 2020
@anikethsaha anikethsaha added pinned This is to pinned the PR/Issue in order to keep it open and removed wontfix labels Feb 4, 2020
@anikethsaha anikethsaha mentioned this pull request Mar 10, 2020
Closed
@acathur acathur mentioned this pull request May 10, 2020
Closed
@trusktr
Copy link
Member

trusktr commented Jun 8, 2020

Develop has diverged from this PR. There's 11 files with conflicts. What do we want to do?

I think we either

  • take effort to clean up the PR
  • or close it, and open a new branch

Either way, we should not let existing branches get stale. After each pull request is merged, we should merge develop into the breaking-release branch (that is, if we want to keep the breaking changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pinned This is to pinned the PR/Issue in order to keep it open

Projects

None yet

Milestone

5.x

Development

Successfully merging this pull request may close these issues.

5 participants

@QingWei-Li @timaschew @trusktr @jhildenbiddle @anikethsaha